Gecko [ v3.cesa.co.za ]

Name	Size	Permission	Date
__pycache__	[ DIR ]	drwxr-xr-x	2026-06-08 18:08
apis	[ DIR ]	drwxr-xr-x	2026-06-08 18:08
cache	[ DIR ]	drwxr-xr-x	2026-06-08 18:08
cli_trees	[ DIR ]	drwxr-xr-x	2026-06-08 18:08
resource_maps	[ DIR ]	drwxr-xr-x	2026-06-08 18:08
resources	[ DIR ]	drwxr-xr-x	2026-06-08 18:08
__init__.py	897 B	-rw-r--r--	1980-01-01 08:00
check_import.py	1.56 KB	-rw-r--r--	1980-01-01 08:00
daemon.py	9.62 KB	-rw-r--r--	1980-01-01 08:00
debug.py	1.62 KB	-rw-r--r--	1980-01-01 08:00
gcloud_command_vocabulary.txt	1.82 KB	-rw-r--r--	1980-01-01 08:00
generate_config_commands.py	2.83 KB	-rw-r--r--	1980-01-01 08:00
generate_help_docs.py	6.76 KB	-rw-r--r--	1980-01-01 08:00
lint.py	9.23 KB	-rw-r--r--	1980-01-01 08:00
lint_gcloud_commands.py	17.54 KB	-rw-r--r--	1980-01-01 08:00
list_commands.py	6.26 KB	-rw-r--r--	1980-01-01 08:00
list_files_for_upload.py	1.49 KB	-rw-r--r--	1980-01-01 08:00
list_from_json.py	2.27 KB	-rw-r--r--	1980-01-01 08:00
list_gcloud.py	1.93 KB	-rw-r--r--	1980-01-01 08:00
render_markdown.py	1.5 KB	-rw-r--r--	1980-01-01 08:00
test.py	7.41 KB	-rw-r--r--	1980-01-01 08:00
validate_yaml.py	1.53 KB	-rw-r--r--	1980-01-01 08:00

Rename

# -*- coding: utf-8 -*- #
# Copyright 2015 Google LLC. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""A command that validates gcloud flags according to Cloud SDK CLI Style."""

import io
import os

from googlecloudsdk.calliope import arg_parsers
from googlecloudsdk.calliope import base
from googlecloudsdk.calliope import usage_text
from googlecloudsdk.core import exceptions
from googlecloudsdk.core import log
from googlecloudsdk.core.util import files

class UnknownCheckError(Exception):
  """An exception when unknown lint check is requested."""

class LintException(exceptions.Error):
  """One or more lint errors found."""

class LintError:
  """Validation failure.

Attributes:
    name: str, The name of the validation that produced this failure.
    command: calliope.backend.CommandCommon, The offending command.
    msg: str, A message indicating what the problem was.
  """

def __init__(self, name, command, error_message):
    self.name = name
    self.command = command
    self.msg = '[{cmd}]: {msg}'.format(
        cmd='.'.join(command.GetPath()), msg=error_message)

class Checker:
  """The abstract base class for all the checks.

Attributes:
    name: A string, the name of this Checker.
    description: string, command line description of this check.
  """

def ForEveryGroup(self, group):
    pass

def ForEveryCommand(self, command):
    pass

def End(self):
    return []

class NameChecker(Checker):
  """Checks if group,command and flags names have underscores or mixed case."""

name = 'NameCheck'
  description = 'Verifies all existing flags not to have underscores.'

def __init__(self):
    super().__init__()
    self._issues = []

def _ForEvery(self, cmd_or_group):
    """Run name check for given command or group."""

if '_' in cmd_or_group.cli_name:
      self._issues.append(LintError(
          name=NameChecker.name,
          command=cmd_or_group,
          error_message=(
              f'command name [{cmd_or_group.cli_name}] has underscores')))

if not (cmd_or_group.cli_name.islower() or cmd_or_group.cli_name.isupper()):
      self._issues.append(LintError(
          name=NameChecker.name,
          command=cmd_or_group,
          error_message=f'command name [{cmd_or_group.cli_name}] mixed case'))

for flag in cmd_or_group.GetSpecificFlags():
      if not any(f.startswith('--') for f in flag.option_strings) and (
          len(flag.option_strings) != 1 or flag.option_strings[0] != '-h'):
        self._issues.append(LintError(
            name=NameChecker.name,
            command=cmd_or_group,
            error_message=(
                f'flag [{",".join(flag.option_strings)}] has no long form')))
      for flag_option_string in flag.option_strings:
        msg = None
        if '_' in flag_option_string:
          msg = f'flag [{flag_option_string}] has underscores'
        if (flag_option_string.startswith('--')
            and not flag_option_string.islower()):
          msg = f'long flag [{flag_option_string}] has upper case characters'
        if msg:
          self._issues.append(LintError(
              name=NameChecker.name, command=cmd_or_group, error_message=msg))

def ForEveryGroup(self, group):
    self._ForEvery(group)

def ForEveryCommand(self, command):
    self._ForEvery(command)

def End(self):
    return self._issues

class BadListsChecker(Checker):
  """Checks command flags that take lists."""

name = 'BadLists'
  description = 'Verifies all flags implement lists properly.'

def __init__(self):
    super().__init__()
    self._issues = []

def _ForEvery(self, cmd_or_group):
    """Checks every command and group."""
    for flag in cmd_or_group.GetSpecificFlags():
      if flag.nargs not in [None, 0, 1]:
        self._issues.append(
            LintError(
                name=BadListsChecker.name,
                command=cmd_or_group,
                error_message=(
                    'flag [{flg}] has nargs={nargs}'.format(
                        flg=flag.option_strings[0], nargs=f"'{str(flag.nargs)}'"
                    )
                ),
            )
        )
      if isinstance(flag.type, arg_parsers.ArgObject):
        # No metavar requirements for ArgObject.
        return
      if isinstance(flag.type, arg_parsers.ArgDict):
        if not (flag.metavar or flag.type.spec):
          self._issues.append(
              LintError(
                  name=BadListsChecker.name,
                  command=cmd_or_group,
                  error_message=(
                      f'dict flag [{flag.option_strings[0]}] has no '
                      'metavar and type.spec (at least one needed)')))
      elif isinstance(flag.type, arg_parsers.ArgList) and not flag.metavar:
        self._issues.append(LintError(
            name=BadListsChecker.name,
            command=cmd_or_group,
            error_message=(
                f'list flag [{flag.option_strings[0]}] has no metavar')))

def ForEveryGroup(self, group):
    self._ForEvery(group)

def ForEveryCommand(self, command):
    self._ForEvery(command)

def End(self):
    return self._issues

def _GetAllowlistedCommandVocabulary():
  """Returns allowlisted set of gcloud commands."""

vocabulary_file = os.path.join(os.path.dirname(__file__),
                                 'gcloud_command_vocabulary.txt')
  return set(
      line for line in files.ReadFileContents(vocabulary_file).split('\n')
      if not line.startswith('#'))

class VocabularyChecker(Checker):
  """Checks that command is the list of allowlisted names."""

name = 'AllowlistedNameCheck'
  description = 'Verifies that every command is allowlisted.'

def __init__(self):
    super().__init__()
    self._allowlist = _GetAllowlistedCommandVocabulary()
    self._issues = []

def ForEveryGroup(self, group):
    pass

def ForEveryCommand(self, command):
    if command.cli_name not in self._allowlist:
      self._issues.append(LintError(
          name=self.name,
          command=command,
          error_message=(
              f'command name [{command.cli_name}] is not allowlisted')))

def End(self):
    return self._issues

def _WalkGroupTree(group):
  """Visits each group in the CLI group tree.

Args:
    group: backend.CommandGroup, root CLI subgroup node.
  Yields:
    group instance.
  """

yield group

for sub_group in group.groups.values():
    yield from _WalkGroupTree(sub_group)

class Linter:
  """Lints gcloud commands."""

def __init__(self):
    self._checks = []

def AddCheck(self, check):
    self._checks.append(check())

def Run(self, group_root):
    """Runs registered checks on all groups and commands."""
    for group in _WalkGroupTree(group_root):
      for check in self._checks:
        check.ForEveryGroup(group)
      for command in group.commands.values():
        for check in self._checks:
          check.ForEveryCommand(command)

issues = []
    for check in self._checks:
      issues.extend(check.End())
    return issues

# List of registered checks, all are run by default.
_DEFAULT_LINT_CHECKS = [
    NameChecker,
]

_LINT_CHECKS = [
    BadListsChecker,
    VocabularyChecker,
]

def _FormatCheckList(check_list):
  buf = io.StringIO()
  for check in check_list:
    usage_text.WrapWithPrefix(
        check.name, check.description, 20, 78, '  ', writer=buf)
  return buf.getvalue()

@base.DefaultUniverseOnly
class Lint(base.Command):
  """Validate gcloud flags according to Cloud SDK CLI Style."""

@staticmethod
  def Args(parser):
    parser.add_argument(
        'checks',
        metavar='CHECKS',
        nargs='*',
        default=[],
        help="""\
A list of checks to apply to gcloud groups and commands.
If omitted will run all available checks.
Available Checks:
""" + _FormatCheckList(_LINT_CHECKS))

def Run(self, args):
    # pylint: disable=protected-access
    group = self._cli_power_users_only._TopElement()
    group.LoadAllSubElements(recursive=True)
    return Lint._SetupAndRun(group, args.checks)

@staticmethod
  def _SetupAndRun(group, check_list):
    """Builds up linter and executes it for given set of checks."""

linter = Linter()
    unknown_checks = []
    if not check_list:
      for check in _DEFAULT_LINT_CHECKS:
        linter.AddCheck(check)
    else:
      available_checkers = dict(
          (checker.name, checker)
          for checker in _DEFAULT_LINT_CHECKS + _LINT_CHECKS)
      for check in check_list:
        if check in available_checkers:
          linter.AddCheck(available_checkers[check])
        else:
          unknown_checks.append(check)

if unknown_checks:
      raise UnknownCheckError(
          f'Unknown lint checks: {",".join(unknown_checks)}')

return linter.Run(group)

def Display(self, args, result):
    writer = log.out
    for issue in result:
      writer.Print(issue.msg)
    if result:
      raise LintException('there were some lint errors.')